fix: resolve PR loading hang with pagination and concurrency control#62
Open
watany-dev wants to merge 2 commits intomainfrom
Open
fix: resolve PR loading hang with pagination and concurrency control#62watany-dev wants to merge 2 commits intomainfrom
watany-dev wants to merge 2 commits intomainfrom
Conversation
GetDifferences and GetCommentsForPullRequest APIs were not handling pagination (NextToken), silently truncating results for large PRs. Blob fetches fired all at once (N files × 2) causing API throttling. - Add pagination loop for GetDifferences in both PR detail and commit diff - Add pagination loop for GetCommentsForPullRequest - Limit concurrent blob fetches to 5 via worker pool pattern - Extract shared fetchBlobTexts helper used by both PR and commit views https://claude.ai/code/session_01MyhBKncxxkLaLfCRxge4yC
getCommitsForPR previously walked only parentIds[0] sequentially. For PRs with merge commits, this followed the wrong branch and made up to 100 sequential API calls before hitting MAX_COMMITS. Rewrite to BFS: each level fetches commits in parallel, all parents are visited, and mergeBase is pre-marked as visited to stop correctly. Also add concurrency control (5 workers) to getReactionsForComments, which was firing all reaction fetches in parallel with no limit. https://claude.ai/code/session_01MyhBKncxxkLaLfCRxge4yC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDifferences and GetCommentsForPullRequest APIs were not handling
pagination (NextToken), silently truncating results for large PRs.
Blob fetches fired all at once (N files × 2) causing API throttling.
https://claude.ai/code/session_01MyhBKncxxkLaLfCRxge4yC